Add a basic makefile #162
Merged
Add a basic makefile #162
+129
−81
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pantierra
force-pushed
the
feature/makefile
branch
13 times, most recently
from
b6c4561 to
6e20b36
Compare
ciaransweet
requested changes
Oct 31, 2024
pantierra
force-pushed
the
feature/makefile
branch
2 times, most recently
from
70ef577 to
c0d34bb
Compare
Contributor
Author
|
Many thanks for the review and suggestions, @ciaransweet! |
pantierra
force-pushed
the
feature/makefile
branch
from
c0d34bb to
5d337f4
Compare
ciaransweet
requested changes
Oct 31, 2024
pantierra
force-pushed
the
feature/makefile
branch
from
e46707f to
1607733
Compare
Co-authored-by: Ciaran Sweet <9111975+ciaransweet@users.noreply.github.com>
pantierra
force-pushed
the
feature/makefile
branch
from
1607733 to
b3a20ed
Compare
ciaransweet
approved these changes
Oct 31, 2024
Contributor
ciaransweet
left a comment
ciaransweet
left a comment
There was a problem hiding this comment.
LGTM!
Didn't test the cloud example but it worked on Minikube which tests the full thing anyway 🎉
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just to: