Add multidim api service. #182
Conversation
pantierra
force-pushed
the
feature/multidimensional-titiler
branch
from
390b37b to
e92d50b
Compare
pantierra
force-pushed
the
feature/multidimensional-titiler
branch
from
e92d50b to
9d949c6
Compare
|
Who are you looking for a review from, @pantierra? |
|
Anybody who wants, I'd appreciate it, ideally @ividito and/or @ciaransweet. |
ciaransweet
left a comment
ciaransweet
left a comment
There was a problem hiding this comment.
LGTM! Just a general question on one of the tests
| pattern: ^multidim-envvar-configmap-RELEASE-NAME$ | ||
| - equal: | ||
| path: data.GDAL_HTTP_MULTIPLEX | ||
| value: "YES" |
There was a problem hiding this comment.
Guess checking one implies the rest worked? Or is this value very special to check?
There was a problem hiding this comment.
This variable is set by titiler whenever it supports multidimensional datasets. There might be issues on titiler but those are/should be tested within the app's test. For the deployment it seems a good initial test to see if the capabilities are activated. We might add some actual data test later, though.
|
Many thanks for the review, @ciaransweet ❤️ |
| tag: 0ea56bfa44457b92e804fd4c0c2192019c002965 | ||
| command: | ||
| - "uvicorn" | ||
| - "titiler.pgstac.main:app" |
There was a problem hiding this comment.
does this need to be app.main:app?
There was a problem hiding this comment.
Thanks for noticing. titiler_md_demo.main:app we need: #192
This PR proposes adding another titiler service for multidimensional data support with endpoints under
/multidim. It is based on titiler-md-demo.Related to EOEPCA/data-access#138