Add initContainers to wait for db and it's bootstrap. #194
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pantierra
force-pushed
the
feature/wait-for-db-and-bootstrap
branch
from
360149e to
25c868e
Compare
pantierra
changed the title
pantierra
force-pushed
the
feature/wait-for-db-and-bootstrap
branch
4 times, most recently
from
7e39cb7 to
3d6f35b
Compare
pantierra
force-pushed
the
feature/wait-for-db-and-bootstrap
branch
from
3d6f35b to
2403fff
Compare
ividito
reviewed
Apr 1, 2025
ividito
approved these changes
Apr 1, 2025
batpad
reviewed
Apr 2, 2025
| app: {{ $serviceName }}-{{ $.Release.Name }} | ||
| spec: | ||
| serviceAccountName: eoapi-sa-{{ $.Release.Name }} | ||
| {{- if eq $serviceName "stac" }} |
Member
There was a problem hiding this comment.
I worry a bit about these conditionals - if we start having more conditionals for each service, this seems like it could get ugly real quick. This is definitely fine for now, but this is something I'd think about and revisit as soon as we have even another conditional for a specific service.
Contributor
Author
There was a problem hiding this comment.
Totally agree. This was one (unrelated) attempt to reduce conditionals: #161
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.