Refactor pgstacbootstrap job and ConfigMaps to use Helm hooks for execution order #207
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emmanuelmathot
requested review from
Copilot,
ividito and
pantierra
and removed request for
ividito and
pantierra
Contributor
There was a problem hiding this comment.
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
Comments suppressed due to low confidence (2)
helm-chart/eoapi/templates/pgstacboostrap/job.yaml:16
- [nitpick] There is an inconsistency between the folder name 'pgstacboostrap' and the job name 'pgstacbootstrap'. Consider renaming the folder to 'pgstacbootstrap' for consistency.
name: pgstacbootstrap
.github/workflows/helm-tests.yml:181
- [nitpick] The log extraction command uses 'svc/vector', which deviates from the naming pattern seen elsewhere (e.g., using the release name). Verify whether this is intentional or if it should align with the other service naming conventions.
pytest .github/workflows/tests/test_vector.py || kubectl logs svc/vector
This was referenced Apr 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement Helm hooks to manage the execution order of the pgstacbootstrap job and its ConfigMaps, eliminating the need for initContainers in the deployment. This change ensures proper initialization of the PostgreSQL database during installation and upgrades.
related issues: #203, #206