Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .github/workflows/helm-tests.yml
Original file line number Diff line number Diff line change
Expand Up @@ -122,8 +122,8 @@ jobs:

- name: run the tests
run: |
# first substitute test enpoints in the test files
# TODO: pytest should be able to have a pattern for injection here but htis is quicker
# first substitute test endpoints in the test files
# TODO: pytest should be able to have a pattern for injection here but moving fast
URL=$(minikube service vector --url)
sed -i "s|vector_endpoint\=.*$|vector_endpoint\='$URL'|g" .github/workflows/tests/test_vector.py
head -n 5 .github/workflows/tests/test_vector.py
Expand Down
4 changes: 4 additions & 0 deletions .github/workflows/release.yml
Original file line number Diff line number Diff line change
Expand Up @@ -36,6 +36,10 @@ jobs:
# create the index file
helm repo index .

# update `values.yaml` with a gitSha
COMMITSHA=$(git rev-parse HEAD | cut -c1-10)
sed -i "s|gitSha: \"\"|gitSha: \"$COMMITSHA\"|g" "$helm-chart"/values.yaml

git add -A
chart_version=$(cat $chart/Chart.yaml| grep version: | cut -d' ' -f2)
git commit -m $chart_version
Expand Down
1 change: 0 additions & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -68,7 +68,6 @@ Once you have a k8s cluster set up you can `helm install` eoAPI as follows

# add the required secret overrides to an arbitrarily named `.yaml` file (`config.yaml` below)
$ cat config.yaml
gitSha: "AB123"
db:
settings:
secrets:
Expand Down
4 changes: 3 additions & 1 deletion helm-chart/eoapi/values.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -64,7 +64,9 @@ db:
# "gcp" will be an option available in the future
providerContext: "aws"

gitSha: ""
# if running `helm install` from repo directory you'll have to provide this
# otherwise the chart on the gh-pages branch will provide the correct updated value
gitSha: "gitshaABC123"

service:
port: 8080
Expand Down