refactor: Check on existing integration tests #284
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pantierra
requested review from
batpad,
ciaransweet,
emmanuelmathot and
sunu
pantierra
force-pushed
the
feature/review-integration-tests
branch
from
35fba24 to
9aa2d38
Compare
ciaransweet
requested changes
Sep 10, 2025
.github/workflows/helm-tests.yml
Outdated
| if: github.event.pull_request.head.repo.full_name == github.repository | ||
| integration: | ||
| name: Integration Tests (K3s) | ||
| # if: github.event.pull_request.head.repo.full_name == github.repository |
Contributor
Author
There was a problem hiding this comment.
Debug shiz. Took the comment away. Thanks for spotting it.
.github/workflows/helm-tests.yml
Outdated
| echo "LAST_COMMIT_SHA=${GITHUB_SHA}" >> ${GITHUB_ENV} | ||
| SHORT_SHA="${{ github.sha }}" | ||
| SHORT_SHA="${SHORT_SHA::8}" | ||
| SALT=$(echo "$RANDOM" | cut -c1-3) |
Contributor
There was a problem hiding this comment.
is the salt needed? It's a local cluster right we shouldn't get conflicts?
Contributor
Author
There was a problem hiding this comment.
Yes, not necessary in this context. Removed.
Makefile
Outdated
| help: | ||
| @echo "Makefile commands:" | ||
| @echo " make deploy - Install eoAPI on a cluster kubectl is connected to." | ||
| @echo " make deploy - Deploy eoAPI with on connected Kubernetes cluster." |
Contributor
There was a problem hiding this comment.
Suggested change
| @echo " make deploy - Deploy eoAPI with on connected Kubernetes cluster." | |
| @echo " make deploy - Deploy eoAPI to the configured Kubernetes cluster." |
pantierra
force-pushed
the
feature/review-integration-tests
branch
from
9aa2d38 to
2b51600
Compare
ciaransweet
approved these changes
Sep 11, 2025
pantierra
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the first step to review the CI tests (#200 ):
make integration.scripts, ordered them into three:deploy.sh,test.shandingest.sh