-
Notifications
You must be signed in to change notification settings - Fork 12
refactor: Restructure values in service profiles. #351
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
252df2a to
e727ef3
Compare
| monitoring: | ||
| metricsServer: | ||
| enabled: false | ||
| prometheus: | ||
| enabled: false | ||
| prometheusAdapter: | ||
| enabled: false | ||
|
|
||
| observability: | ||
| grafana: | ||
| enabled: false |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd maybe consider these 'production/core'?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would prefer to keep the core.yaml rather conservatively small. But it probably makes sense to add a production.yaml version with them being enabled. Kind of a "what we would deploy for a partner usually". But maybe in another PR?
core.yaml should be more like the things we are confident they are stable. Potentially also give a different warning on these when there are breaking changes than on the others.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would maybe change the wording around it then as it mentions Production-ready deployment
Which yes, but I would say maybe stable
Fits the counterpart that is experimental
|
Thanks a lot for the review! |
This introduces Service Profile presets for common deployment scenarios:
profiles/core.yaml- Production-ready deployment with stable services only (STAC, Raster, Vector)profiles/experimental.yaml- Full feature set including experimental components (Multidim, STAC Browser, Notifications, Knative, Monitoring)profiles/local/k3s.yaml- k3s-specific overrides for local development (inherits from experimental)profiles/local/minikube.yaml- Minikube-specific overrides for local development (inherits from experimental)profiles/README.mdWhat i have done? Reorganized local development values files into structured profiles directory:
local-base-values.yamltoprofiles/experimental.yamllocal-k3s-values.yamltoprofiles/local/k3s.yaml(now inherits from experimental)local-minikube-values.yamltoprofiles/local/minikube.yaml(now inherits from experimental)deploy.shscript to use new profile paths