-
Notifications
You must be signed in to change notification settings - Fork 12
feat: Added support for ConfigMap reference-based queryables configuration #360
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
@pantierra My integration tests wont work because of a wrong stac_endpoint setup in the integration tests. Can you please help me find out? |
|
Thanks for the PR! I would like to look into this after streamlining the test scripts #359. |
df0c9f4 to
cdbb8e0
Compare
|
I think the stac endpoint has been fixed with the refactoring of the testing scripts. I rebased this PR and fixed the tests. Please have a look @emmanuelmathot and maybe we want to discuss the json input vs. output. |
|
Thank you very much @pantierra for the test adjustment. Indeed, there is no reason to test the id nor the title. The most important is to check each properties of the queryables. |
|
@batpad with this PR we should be able to configure queryables from argocd for Monty. |
|
@emmanuelmathot this looks super, thank you! Just curious on the rationale to support mounting a JSON file as well as specifying a ConfigMap reference. Supporting both seems to add a bit of complexity and just curious what scenarios you imagine specifying a file would be better than a ConfigMap reference. The ConfigMap reference to me seems clean and flexible, and am just double-checking that we do need to support multiple ways of doing this. Of course, the PR looks great to me and seems perfect to try out on the Monty setup, ty! |
What I am changing
How I did it
charts/eoapi/templates/database/pgstacbootstrap/configmap.yamlto support both file-based andconfigMapRefqueryables using a mandatorynamefieldcharts/eoapi/templates/database/pgstacbootstrap/job.yamlto properly mount queryables from both sources and generate appropriatepypgstac load-queryablescommandscharts/eoapi/values.yamlwith clear documentation and examples for both configuration modescharts/eoapi/tests/queryables_tests.yamlwith 18 Helm unit tests covering all scenarios (file-based, configMapRef, mixed, optional parameters, edge cases)test_stac_queryables()integration test in.github/workflows/tests/test_stac.pyto validate the/queryablesendpoint returns expected datascripts/test.shto automatically run the queryables integration test as part of the test suiteHow you can test it
Helm Unit Tests:
Integration Test (requires deployed eoAPI):
Configuration Examples:
Related Issues