Skip to content

Conversation

@hrodmn
Copy link
Contributor

@hrodmn hrodmn commented Apr 18, 2025

@hrodmn hrodmn requested review from emmalu and zacdezgeo April 18, 2025 01:24
@hrodmn hrodmn self-assigned this Apr 18, 2025
@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@hrodmn hrodmn force-pushed the feat/introduction branch from 0a80739 to 23adf58 Compare April 18, 2025 15:04
@zacdezgeo
Copy link

Some really good new content here @hrodmn ! Sharing for visibility with @kcarini . You might have feedback on the notebook also!

@hrodmn hrodmn requested a review from alukach April 21, 2025 16:27
@hrodmn hrodmn changed the title add introduction notebook (lecture material) add workshop notebooks Apr 22, 2025
@review-notebook-app
Copy link

review-notebook-app bot commented Apr 22, 2025

View / edit / reply to this conversation on ReviewNB

wildintellect commented on 2025-04-22T23:26:24Z
----------------------------------------------------------------

ergonomic and consistent


@review-notebook-app
Copy link

review-notebook-app bot commented Apr 22, 2025

View / edit / reply to this conversation on ReviewNB

wildintellect commented on 2025-04-22T23:26:25Z
----------------------------------------------------------------

data providers or community


@@ -0,0 +1,8574 @@
{
Copy link

@wildintellect wildintellect Apr 22, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe truncate the results a little?


Reply via ReviewNB

@@ -0,0 +1,510 @@
{
Copy link
Member

@emmalu emmalu Apr 23, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a required 'install' step? Asking because an attempt to run this code snippet:

import boto3
from botocore import UNSIGNED
from botocore.client import Config
from s3pathlib import S3Path


region = "us-west-2"
bucket_name = "sentinel-cogs"
prefix = "sentinel-s2-l2a-cogs/28/G/GV/2025/4/S2B_28GGV_20250417_0_L2A/"


s3 = boto3.client("s3", region_name=region, config=Config(signature_version=UNSIGNED))
s3_keys = []


results in this error:

---------------------------------------------------------------------------
ModuleNotFoundError                       Traceback (most recent call last)
Cell In[1], line 1
----> 1 import boto3
      2 from botocore import UNSIGNED
      3 from botocore.client import Config

ModuleNotFoundError: No module named 'boto3'

Reply via ReviewNB

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

did you install with the conda environment after the most recent comit? I had to re-add boto3 to the environment.yml this afternoon.

@hrodmn hrodmn merged commit ea78156 into main Apr 23, 2025
@hrodmn hrodmn deleted the feat/introduction branch April 23, 2025 11:15
@review-notebook-app
Copy link

review-notebook-app bot commented Apr 23, 2025

View / edit / reply to this conversation on ReviewNB

wildintellect commented on 2025-04-23T18:00:07Z
----------------------------------------------------------------

3.1.1 and 3.1.2 seems more like Notes/Documentation than workshop actions for users to take. Maybe they should be markdown notes or pushed to a reference section.

3.1.3 is this informational or are users deploying a local eoAPI for testing?


@review-notebook-app
Copy link

review-notebook-app bot commented Apr 23, 2025

View / edit / reply to this conversation on ReviewNB

wildintellect commented on 2025-04-23T18:00:08Z
----------------------------------------------------------------

404 that needs a little more explanation, or reference to where to learn about the API options.


@review-notebook-app
Copy link

review-notebook-app bot commented Apr 23, 2025

View / edit / reply to this conversation on ReviewNB

wildintellect commented on 2025-04-23T18:00:09Z
----------------------------------------------------------------

collection -> collections


@review-notebook-app
Copy link

review-notebook-app bot commented Apr 23, 2025

View / edit / reply to this conversation on ReviewNB

wildintellect commented on 2025-04-23T18:00:10Z
----------------------------------------------------------------

IFrame is cool but weird, would we not want people to visit this page in another browser tab/window so they know it exists as a webpage any time their service is running?


Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants