fix: Remove fileUpload dep in useStacValue useEffect #177
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sandrahoang686
changed the title
gadomski
reviewed
Oct 29, 2025
gadomski
approved these changes
Oct 30, 2025
|
🎉 This PR is included in version 0.9.6 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So when reviewing the error boundary PR #176 which I did a couple of days ago.. apologies for not approving and bringing this up sooner but I realized the app looked like it was infinitely rendering.. Is this supposed to happen?? If not, I went down a path trying to figure out where this was happening. It looked like the
useStacValuehook's useEffect had a depfileUploadwhich is hook from chakra that was causing this.This PR just removes that dep to stop the app from infinitely rendering. But maybe this could be solved another way? Either way, I dont think this should cause a big issue having that missing dep as I think it will still be stable enough. What do you think @gadomski?
Behavior before (infinite render):
stac_map_infinite_render_ex.mov
Behavior now:
stac_map_infinite_render_fix.mov