Skip to content

fix: don't set bbox for empty feature collections #130

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 12, 2025
Merged

fix: don't set bbox for empty feature collections #130

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions src/components/map.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -119,7 +119,6 @@ export default function Map() {
updateTriggers: [picked, items],
}),
];
console.log(geojson);

if (stacGeoparquetTable) {
layers.push(
Expand Down Expand Up @@ -233,7 +232,10 @@ function useStacValueLayerProperties(
case "FeatureCollection":
return {
geojson: value.features as Feature[],
bbox: turfBbox(value as FeatureCollection),
bbox:
(value.features.length > 0 &&
turfBbox(value as FeatureCollection)) ||
undefined,
filled: true,
};
}
Expand Down
10 changes: 10 additions & 0 deletions tests/app.spec.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,3 +41,13 @@ test("loads CSDA Planet", async () => {
.element(app.getByRole("heading", { hasText: "Planet" }))
.toBeVisible();
});

test("loads NAIP stac-geoparquet", async () => {
window.history.pushState(
{},
"",
"?href=https://raw.githubusercontent.com/developmentseed/labs-375-stac-geoparquet-backend/refs/heads/main/data/naip.parquet",
);
const app = await renderApp();
await expect.element(app.getByText(/stac-geoparquet/i)).toBeVisible();
});