-
Notifications
You must be signed in to change notification settings - Fork 4
Open
Description
@danielfdsilva spent time in #24 improving the GitHub workflow.
To keep our git history clean and make reviews easier, we should extract the workflow improvements into their own PR, based on the develop branch.
GitHub Actions Workflow Updates (.github/workflows/checks.yml)
- Add descriptive header comments explaining the workflow purpose
- Update trigger conditions:
- Remove
pushtrigger onmainbranch - Update
pull_requesttypes to:opened,synchronize,reopened,ready_for_review - Add concurrency controls to cancel in-progress runs for the same ref
- Remove
- Update Node.js version strategy:
- Remove hardcoded
NODEenvironment variable - Use
node-version-file: '.nvmrc'to read version from.nvmrcfile
- Remove hardcoded
- Update GitHub Actions to latest versions:
actions/checkout@v2→actions/checkout@v4actions/setup-node@v1→actions/setup-node@v4actions/cache@v2→actions/cache@v4- Remove deprecated
styfle/cancel-workflow-action(replaced by concurrency)
- Simplify cache key:
- Remove
cache-nameenvironment variable - Use
${{ runner.os }}-build-${{ hashFiles('**/package.json') }}
- Remove
- Update job commands:
- Use explicit
yarn run lintinstead ofyarn lint - Use explicit
yarn run testinstead ofyarn test - Use explicit
yarn run buildinstead ofyarn build - Fix build job step name: "Test" → "Build"
- Use explicit
- Ensure
buildjob depends ontestjob (not changed, but verify)
References
- Original PR: Alpha 11 #24
- Target branch:
develop
Notes
This is purely infrastructure/tooling changes with no functional code changes to the library itself.
Metadata
Metadata
Assignees
Labels
No labels