Enable TLS for version 1 #40
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Michael Valdron <mvaldron@redhat.com>
michael-valdron
requested review from
johnmcollier,
maysunfaisal,
thepetk and
yangcao77
thepetk
approved these changes
Jan 3, 2024
Contributor
thepetk
left a comment
thepetk
left a comment
There was a problem hiding this comment.
/lgtm I've started a console instance locally using the updated sample and I was able to build an application from it. I didn't see an issue in the updated hac tests either.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Set
securetotrueto prompt devtools, such as ODC, to create a route with tls enabled.This should enable TLS on OpenShift for this sample when web console has been patched: devfile/api#1270 (comment)
fixes part of devfile/api#1270