separate spring boot and spring cloud from spring detection

[haoozhang]

Description of Changes

For a pure Spring (non-Spring Boot) project, currently it detects as Spring, Spring Boot because of hardcoded frameworks.
This PR is to separate the Spring Boot, Spring Cloud from Spring detection.

Related Issue(s)

Link the GitHub/GitLab/JIRA issues that are related to this PR.

Acceptance Criteria

Testing and documentation do not need to be complete in order for this PR to be approved. However, tracking issues must be opened for missing testing/documentation.

• Unit/Functional tests

• Documentation

Tests Performed

• For a pure Spring project, it detects as Spring only, no Spring Boot.
• For a Spring Boot project, it detects as Spring, Spring Boot.

How To Test

Instructions for the reviewer on how to test your changes.

Notes To Reviewer

Any notes you would like to include for the reviewer.

[openshift-ci]

@zhoufenqin: changing LGTM is restricted to collaborators

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[haoozhang]

Hi @Jdubrick @thepetk , could you please help to review this PR, thanks!

[thepetk]

Hey @haoozhang thank you for your contribution!

That's a nice enhancement you're suggesting. Just to mention my approach to this would
be to just expand the logic of the springDetector, as I see the three implementations are quite similar.

So I would add different cases here (one of spring, spring boot or spring cloud)

https://github.com/devfile/alizer/blob/main/pkg/apis/enricher/framework/java/spring_detector.go#L55-L59

My other comment is about test cases. It would be awesome if you could add some test cases (similar to what we have right now for spring) so we are sure that alizer after the updates detects correctly the cloud and boot frameworks all the time.

[haoozhang]

Hey @haoozhang thank you for your contribution!

That's a nice enhancement you're suggesting. Just to mention my approach to this would be to just expand the logic of the springDetector, as I see the three implementations are quite similar.

So I would add different cases here (one of spring, spring boot or spring cloud)

https://github.com/devfile/alizer/blob/main/pkg/apis/enricher/framework/java/spring_detector.go#L55-L59

My other comment is about test cases. It would be awesome if you could add some test cases (similar to what we have right now for spring) so we are sure that alizer after the updates detects correctly the cloud and boot frameworks all the time.

Thanks for your comment, I updated the PR, please help to review again, thanks!

[thepetk]

Hey @haoozhang thank you for your contribution!
That's a nice enhancement you're suggesting. Just to mention my approach to this would be to just expand the logic of the springDetector, as I see the three implementations are quite similar.
So I would add different cases here (one of spring, spring boot or spring cloud)
https://github.com/devfile/alizer/blob/main/pkg/apis/enricher/framework/java/spring_detector.go#L55-L59
My other comment is about test cases. It would be awesome if you could add some test cases (similar to what we have right now for spring) so we are sure that alizer after the updates detects correctly the cloud and boot frameworks all the time.

Thanks for your comment, I updated the PR, please help to review again, thanks!

Thanks @haoozhang for the updates! One last thing I'd ask is to add test cases for the spring cloud detection too. We could simply add small resource project in the projects dir and then add a test case here: https://github.com/devfile/alizer/blob/main/test/apis/component_recognizer_test.go

[haoozhang]

Hey @haoozhang thank you for your contribution!
That's a nice enhancement you're suggesting. Just to mention my approach to this would be to just expand the logic of the springDetector, as I see the three implementations are quite similar.
So I would add different cases here (one of spring, spring boot or spring cloud)
https://github.com/devfile/alizer/blob/main/pkg/apis/enricher/framework/java/spring_detector.go#L55-L59
My other comment is about test cases. It would be awesome if you could add some test cases (similar to what we have right now for spring) so we are sure that alizer after the updates detects correctly the cloud and boot frameworks all the time.

Thanks for your comment, I updated the PR, please help to review again, thanks!

Thanks @haoozhang for the updates! One last thing I'd ask is to add test cases for the spring cloud detection too. We could simply add small resource project in the projects dir and then add a test case here: https://github.com/devfile/alizer/blob/main/test/apis/component_recognizer_test.go

@thepetk Comment updated, please help to review again, thanks!

[thepetk]

/ok-to-test

[thepetk]

/lgtm

@haoozhang huge thanks for your contribution <3

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: haoozhang, thepetk, zhoufenqin

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [thepetk]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment