Helm Chart expects `global.ingress.domain` to be set for OpenShift clusters

[michael-valdron]

Which area this feature is related to?

/kind bug

Which area this bug is related to?

/area registry

Describe the bug:

Helm Chart expects global.ingress.domain to be set when targeting OpenShift clusters. Anything set under global.ingress should only pertain to k8s environments.

To Reproduce:

Just using helm install devfile-registry deploy/chart/devfile-registry --set global.isOpenShift=true leads to links pointing to devfile registry server endpoints to be not found, because it will use the current default value for global.ingress.domain.

Using helm install devfile-registry deploy/chart/devfile-registry --set global.isOpenShift=true --set global.ingress.domain=<openshift-route-domain> will fix this behavior for the deployment.

Expected behavior

According to current documentation, should not expect a domain name to be passed, alternatively should be separated from ingress fields, i.e. global.route.domain.

Any logs, error output, screenshots etc? Provide the devfile that sees this bug, if applicable

Additional context

Any workaround?

Seperate domain setting for OpenShift environments to be under global.route rather than global.ingress, apply this to Route template and DEVFILE_REGISTRIES environment variable under the registry-viewer deployment spec, and under documentation to describe this.

Suggestion on how to fix the bug

Ideally, the domain for OpenShift environments should be fetched on deployment to best suite current documentation and sync with registry-operator. However, the workaround approach could be used if technical limitations of the helm chart prevents this solution from working.