chore: Import certificates on the start #240
Conversation
Signed-off-by: Anatolii Bazko <abazko@redhat.com>
|
Pull Request UBI 10 images published ✨ Base Image: quay.io/devfile/base-developer-image:ubi10-pr-240 |
1 similar comment
|
Pull Request UBI 10 images published ✨ Base Image: quay.io/devfile/base-developer-image:ubi10-pr-240 |
|
Pull Request images published ✨ |
1 similar comment
|
Pull Request images published ✨ |
| is_cert=false | ||
| echo "$line" >> ${tmp_file} | ||
| keytool -import -trustcacerts -cacerts -storepass "$KEYSTORE_PASSWORD" -noprompt -alias "${bundle_name}_${cert_index}" -file $tmp_file | ||
| certs_imported=$((certs_imported+1)) |
There was a problem hiding this comment.
Can we check the keytool command for an error and increment certs_imported only if there is no error?
|
It's working as expected: 
|
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: dkwon17, tolusha The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
New changes are detected. LGTM label has been removed. |
|
Pull Request UBI 10 images published ✨ Base Image: quay.io/devfile/base-developer-image:ubi10-pr-240 |
|
Pull Request images published ✨ |
Reference issue
eclipse-che/che#23555
Admin can add extra certificates by following the guide [1]
The problem is that those certificates are not automatically added to java key store
This PR improves that.
[1] https://eclipse.dev/che/docs/stable/administration-guide/importing-untrusted-tls-certificates/