Skip to content

Conversation

gabriel-rh
Copy link
Contributor

@gabriel-rh gabriel-rh commented Oct 28, 2022

Signed-off-by: Gabriel McGoldrick gmcgoldr@redhat.com

What does this PR do / why we need it

Document new kind of project: starterProjects

Which issue(s) does this PR fix

https://issues.redhat.com/browse/RHDEVDOCS-2562

Fixes #?

PR acceptance criteria

  • Unit Tests
  • E2E Tests
  • Documentation

How to test changes / Special notes to the reviewer

Preview available at https://gabriel-rh.github.io/devfile-previews/PR54/

Signed-off-by: Gabriel McGoldrick <gmcgoldr@redhat.com>
@nx-cloud
Copy link

nx-cloud bot commented Oct 28, 2022

☁️ Nx Cloud Report

CI is running/has finished running commands for commit be23dfb. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch


✅ Successfully ran 5 targets

Sent with 💌 from NxCloud.

@openshift-ci openshift-ci bot requested review from elsony and schultzp2020 October 28, 2022 09:48
@gabriel-rh gabriel-rh force-pushed the RHDEVDOCS-2562-starterProjects220 branch from ed0866d to 6cfc6fd Compare October 31, 2022 13:02
Signed-off-by: Gabriel McGoldrick <gmcgoldr@redhat.com>
Signed-off-by: Gabriel McGoldrick <gmcgoldr@redhat.com>
Copy link
Member

@michael-valdron michael-valdron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm label Nov 3, 2022
@openshift-ci openshift-ci bot removed the lgtm label Nov 3, 2022
Copy link
Member

@michael-valdron michael-valdron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm label Nov 3, 2022
@openshift-ci
Copy link

openshift-ci bot commented Nov 3, 2022

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: gabriel-rh, michael-valdron
Once this PR has been reviewed and has the lgtm label, please assign mike-hoang for approval by writing /assign @mike-hoang in a comment. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@michael-valdron michael-valdron merged commit 47e499b into devfile:main Nov 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants