-
Notifications
You must be signed in to change notification settings - Fork 68
Closed
Milestone
Description
Description
The DevWorkspace Operator does not watch PVCs for events, and so does not trigger reconciles if the PVC used by per-workspace DevWorkspaces is modified/deleted.
How To Reproduce
- Start a per-workspace DevWorkspace:
oc apply -f samples/theia-next_per-workspaceStorage.yaml
- Wait for workspace to reach running state
- Edit the
storage-<workspaceID>
PVC by adding e.g. an annotation -- note no reconcile is triggered - Delete the
storage-<workspaceID>
PVC and note that the DevWorkspace stays in therunning
state (it should fail to allow the PVC to be cleaned up)
Expected behavior
- DWO should queue reconciles for the owner DevWorkspace when the PVC is modified
- DWO should fail the per-workspace DevWorkspace if the PVC is deleted. This is pretty important as otherwise the running pod of the workspace will prevent the PVC from being cleaned up.