Skip to content

Changes to the per-workspace PVC do not trigger reconciles #881

@amisevsk

Description

@amisevsk

Description

The DevWorkspace Operator does not watch PVCs for events, and so does not trigger reconciles if the PVC used by per-workspace DevWorkspaces is modified/deleted.

How To Reproduce

  1. Start a per-workspace DevWorkspace: oc apply -f samples/theia-next_per-workspaceStorage.yaml
  2. Wait for workspace to reach running state
  3. Edit the storage-<workspaceID> PVC by adding e.g. an annotation -- note no reconcile is triggered
  4. Delete the storage-<workspaceID> PVC and note that the DevWorkspace stays in the running state (it should fail to allow the PVC to be cleaned up)

Expected behavior

  • DWO should queue reconciles for the owner DevWorkspace when the PVC is modified
  • DWO should fail the per-workspace DevWorkspace if the PVC is deleted. This is pretty important as otherwise the running pod of the workspace will prevent the PVC from being cleaned up.

Additional context

Metadata

Metadata

Assignees

Labels

No labels
No labels

Type

No type

Projects

No projects

Milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions