-
Notifications
You must be signed in to change notification settings - Fork 68
Enable github action to build v1alphax image #361
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
sleshchenko
merged 2 commits into
devfile:v1.0.0-alphax
from
sleshchenko:latestTerminal
Apr 14, 2021
Merged
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
37 changes: 37 additions & 0 deletions
37
internal-registry/redhat-developer/web-terminal-dev/latest/meta.yaml
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,37 @@ | ||
| apiVersion: v2 | ||
| publisher: redhat-developer | ||
| name: web-terminal-dev | ||
| version: latest | ||
| type: Che Editor | ||
| displayName: Web Terminal | ||
| title: Web Terminal | ||
| description: Web provides the ability to start a terminal inside | ||
| the OpenShift Console. The development version does not run with TLS enabled and | ||
| is intended for development purposes only. | ||
| icon: null | ||
| repository: https://github.com/eclipse/che-machine-exec/ | ||
| firstPublicationDate: "2020-06-01" | ||
| category: Other | ||
| spec: | ||
| endpoints: | ||
| - name: web-terminal | ||
| public: true | ||
| targetPort: 4444 | ||
| attributes: | ||
| protocol: http | ||
| type: ide | ||
| discoverable: false | ||
| secure: true | ||
| cookiesAuthEnabled: true | ||
| containers: | ||
| - name: web-terminal | ||
| image: "quay.io/eclipse/che-machine-exec:nightly" | ||
| command: ["/go/bin/che-machine-exec", | ||
| "--authenticated-user-id", "$(DEVWORKSPACE_CREATOR)", | ||
| "--idle-timeout", "$(DEVWORKSPACE_IDLE_TIMEOUT)", | ||
| "--pod-selector", "controller.devfile.io/workspace_id=$(CHE_WORKSPACE_ID)"] | ||
| ports: | ||
| - exposedPort: 4444 | ||
| env: | ||
| - name: USE_BEARER_TOKEN | ||
| value: true |
36 changes: 36 additions & 0 deletions
36
internal-registry/redhat-developer/web-terminal/latest/meta.yaml
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,36 @@ | ||
| apiVersion: v2 | ||
| publisher: redhat-developer | ||
| name: web-terminal | ||
| version: latest | ||
| type: Che Editor | ||
| displayName: Web Terminal | ||
| title: Web Terminal | ||
| description: Web Terminal provides the ability to start a terminal inside the OpenShift Console. | ||
| icon: null | ||
| repository: https://github.com/eclipse/che-machine-exec/ | ||
| firstPublicationDate: "2020-05-13" | ||
| category: Other | ||
| spec: | ||
| endpoints: | ||
| - name: web-terminal | ||
| public: true | ||
| targetPort: 4444 | ||
| attributes: | ||
| protocol: http | ||
| type: ide | ||
| discoverable: false | ||
| secure: true | ||
| cookiesAuthEnabled: true | ||
| containers: | ||
| - name: web-terminal | ||
| image: "${RELATED_IMAGE_plugin_redhat_developer_web_terminal_4_5_0}" | ||
| command: ["/go/bin/che-machine-exec", | ||
| "--authenticated-user-id", "$(DEVWORKSPACE_CREATOR)", | ||
| "--idle-timeout", "$(DEVWORKSPACE_IDLE_TIMEOUT)", | ||
| "--pod-selector", "controller.devfile.io/workspace_id=$(CHE_WORKSPACE_ID)", | ||
| "--use-tls"] | ||
| ports: | ||
| - exposedPort: 4444 | ||
| env: | ||
| - name: USE_BEARER_TOKEN | ||
| value: true |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since this branch represents the web terminal operator should we just publish to https://quay.io/repository/wto/web-terminal-operator instead?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You reminded me the stuff I planed but forgot - default IMG value in Makefile.
Technically we can, but how good it will be if we'll use WTO image as default value for DWO v1alphax.
I like more the way we have now, when main branch of WTO depends on DWO:alpha https://github.com/redhat-developer/web-terminal-operator/blob/main/manifests/web-terminal.clusterserviceversion.yaml#L38
While quay.io/repository/wto/web-terminal-operator is supposed to host stuff built on brew.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My whole idea with https://issues.redhat.com/projects/WTO/issues/WTO-78 was to make it so that we no longer had to do anything manually after we finish a release (including pushing images built from brew). If we continue with using the images from brew we will always have manual steps after a release. Though, when we create a release I can probably just have a github action on web-terminal-operator that tags the current version of quay.io/devfile/devworkspace-controller:v1alphax and then push that to quay.io/wto/devworkspace-controller so it shouldn't be an issue
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well, for me WTO stuff must be built in brew, otherwise it's not WTO.
It's like if we build Che x branch and push it as CRW.
So, I'm proceeding with the current flow, which does not change anything and automates image build, and separately we can think more about how we can avoid manual post release activities
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If we do it that way though the quay.io/wto bundle will only ever refer to the images on the redhat registry and never the ones in quay.io/wto. The only way to refer to the quay.io/wto images would to build another bundle in a github action, but if we do that then it's also not built in brew and also not technically wto