added volume component and modified other components #135
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Deploy PR Preview failed. |
kim-tsao
reviewed
Feb 4, 2022
docs/modules/user-guide/partials/proc_adding-a-volume-component-to-a-devfile.adoc
Outdated
Show resolved
Hide resolved
|
@kim-tsao thanks so much for the review and help with the yaml examples :) Please see the new commit, |
kim-tsao
reviewed
Feb 8, 2022
docs/modules/user-guide/partials/proc_adding-a-volume-component-to-a-devfile.adoc
Outdated
Show resolved
Hide resolved
abrennan89
reviewed
Feb 8, 2022
docs/modules/user-guide/partials/proc_adding-a-container-component-to-a-devfile.adoc
Outdated
Show resolved
Hide resolved
abrennan89
reviewed
Feb 8, 2022
docs/modules/user-guide/partials/proc_adding-a-volume-component-to-a-devfile.adoc
Outdated
Show resolved
Hide resolved
abrennan89
reviewed
Feb 8, 2022
docs/modules/user-guide/partials/proc_adding-a-volume-component-to-a-devfile.adoc
Outdated
Show resolved
Hide resolved
abrennan89
reviewed
Feb 8, 2022
docs/modules/user-guide/partials/proc_adding-a-volume-component-to-a-devfile.adoc
Outdated
Show resolved
Hide resolved
abrennan89
reviewed
Feb 8, 2022
docs/modules/user-guide/partials/proc_adding-a-volume-component-to-a-devfile.adoc
Outdated
Show resolved
Hide resolved
kim-tsao
reviewed
Feb 8, 2022
docs/modules/user-guide/partials/proc_adding-a-volume-component-to-a-devfile.adoc
Outdated
Show resolved
Hide resolved
kowen-rh
reviewed
Feb 8, 2022
...odules/user-guide/partials/proc_adding-a-kubernetes-or-openshift-component-to-a-devfile.adoc
Outdated
Show resolved
Hide resolved
kowen-rh
reviewed
Feb 8, 2022
...odules/user-guide/partials/proc_adding-a-kubernetes-or-openshift-component-to-a-devfile.adoc
Outdated
Show resolved
Hide resolved
docs/modules/user-guide/partials/proc_adding-a-volume-component-to-a-devfile.adoc
Show resolved
Hide resolved
docs/modules/user-guide/partials/proc_adding-a-volume-component-to-a-devfile.adoc
Outdated
Show resolved
Hide resolved
docs/modules/user-guide/partials/proc_adding-a-volume-component-to-a-devfile.adoc
Outdated
Show resolved
Hide resolved
docs/modules/user-guide/partials/proc_adding-a-volume-component-to-a-devfile.adoc
Outdated
Show resolved
Hide resolved
kowen-rh
reviewed
Feb 8, 2022
docs/modules/user-guide/partials/proc_adding-a-container-component-to-a-devfile.adoc
Outdated
Show resolved
Hide resolved
kim-tsao
approved these changes
Feb 11, 2022
kowen-rh
suggested changes
Feb 11, 2022
docs/modules/user-guide/pages/adding-a-kubernetes-or-openshift-component-to-a-devfile.adoc
Outdated
Show resolved
Hide resolved
docs/modules/user-guide/partials/proc_adding-a-volume-component-to-a-devfile.adoc
Outdated
Show resolved
Hide resolved
docs/modules/user-guide/partials/proc_adding-a-volume-component-to-a-devfile.adoc
Outdated
Show resolved
Hide resolved
|
@robin-owen: changing LGTM is restricted to collaborators In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
rkratky
requested changes
Feb 13, 2022
docs/modules/user-guide/pages/adding-a-kubernetes-or-openshift-component-to-a-devfile.adoc
Outdated
Show resolved
Hide resolved
docs/modules/user-guide/pages/adding-a-kubernetes-or-openshift-component-to-a-devfile.adoc
Outdated
Show resolved
Hide resolved
...odules/user-guide/partials/proc_adding-a-kubernetes-or-openshift-component-to-a-devfile.adoc
Outdated
Show resolved
Hide resolved
...odules/user-guide/partials/proc_adding-a-kubernetes-or-openshift-component-to-a-devfile.adoc
Outdated
Show resolved
Hide resolved
docs/modules/user-guide/partials/proc_adding-a-volume-component-to-a-devfile.adoc
Outdated
Show resolved
Hide resolved
docs/modules/user-guide/partials/proc_adding-components-to-a-devfile.adoc
Outdated
Show resolved
Hide resolved
docs/modules/user-guide/partials/proc_adding-components-to-a-devfile.adoc
Outdated
Show resolved
Hide resolved
…-component-to-a-devfile.adoc Co-authored-by: Robert Krátký <rkratky@redhat.com>
…-component-to-a-devfile.adoc Co-authored-by: Robert Krátký <rkratky@redhat.com>
…penshift-component-to-a-devfile.adoc Co-authored-by: Robert Krátký <rkratky@redhat.com>
…penshift-component-to-a-devfile.adoc Co-authored-by: Robert Krátký <rkratky@redhat.com>
…evfile.adoc Co-authored-by: Robert Krátký <rkratky@redhat.com>
…evfile.adoc Co-authored-by: Robert Krátký <rkratky@redhat.com>
… jcberger_devfilecomponents
rkratky
approved these changes
Feb 21, 2022
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: jc-berger, kim-tsao, rkratky The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes devfile/api#260