-
Notifications
You must be signed in to change notification settings - Fork 32
Added devfile properties #55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added devfile properties #55
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: jc-berger The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few minor issues to fix. Otherwise /lgtm
@rolfedh: changing LGTM is restricted to collaborators In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: jc-berger, rolfedh The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Fixes #312.
As a reference, I'm trying to replicate the structure in the odo devfile properties table.
See the conversation in the merged PR, #53.
Also, does anyone know why there's all the api reference file changes? I've only created two new docs, the devfile properties user guide and partials doc and then added this new devfile property doc to the nav doc. I'm not sure why there's all these extra api file changes. Thanks!