Skip to content

Conversation

jc-berger
Copy link
Contributor

Fixes #312.

As a reference, I'm trying to replicate the structure in the odo devfile properties table.

See the conversation in the merged PR, #53.

Also, does anyone know why there's all the api reference file changes? I've only created two new docs, the devfile properties user guide and partials doc and then added this new devfile property doc to the nav doc. I'm not sure why there's all these extra api file changes. Thanks!

@jc-berger jc-berger added the documentation Improvements or additions to documentation label Apr 29, 2021
@jc-berger jc-berger self-assigned this Apr 29, 2021
@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: jc-berger

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link
Contributor

@rolfedh rolfedh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few minor issues to fix. Otherwise /lgtm

@openshift-ci
Copy link

openshift-ci bot commented May 10, 2021

@rolfedh: changing LGTM is restricted to collaborators

In response to this:

A few minor issues to fix. Otherwise /lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci
Copy link

openshift-ci bot commented May 10, 2021

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: jc-berger, rolfedh

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jc-berger
Copy link
Contributor Author

Due to rebase and push issues, I've created a new PR, #69.

All the content changes in this PR is reflected in #69. I'm closing this issue since we'll work on and merge #69 instead.

@jc-berger jc-berger closed this May 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Consolidate devfile docs by pulling in generic content from odo devfile docs

5 participants