Skip to content

Helm Specs Update #221

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 11, 2024
Merged

Helm Specs Update #221

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
344788d
update timeout values for index server and registry viewer
Jdubrick Mar 6, 2024
00df100
add securitycontext and remove env file
Jdubrick Mar 8, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 11 additions & 15 deletions deploy/chart/devfile-registry/templates/deployment.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,6 +38,13 @@ spec:
release: "{{ .Release.Name }}"
heritage: "{{ .Release.Service }}"
spec:
{{- if .Values.persistence.enabled }}
securityContext:
runAsNonRoot: true
runAsUser: 1001
runAsGroup: 2001
fsGroup: 3001
{{- end }}
volumes:
- name: devfile-registry-storage
{{- if .Values.persistence.enabled }}
Expand All @@ -52,12 +59,6 @@ spec:
items:
- key: registry-config.yml
path: config.yml
- name: viewer-env-file
configMap:
name: {{ template "devfileregistry.fullname" . }}
items:
- key: .env.registry-viewer
path: .env.production
containers:
- image: "{{ .Values.devfileIndex.image }}:{{ .Values.devfileIndex.tag }}"
imagePullPolicy: {{ .Values.devfileIndex.imagePullPolicy }}
Expand Down Expand Up @@ -87,8 +88,8 @@ spec:
port: 3000
scheme: HTTP
initialDelaySeconds: 30
periodSeconds: 1
timeoutSeconds: 10
periodSeconds: 10
timeoutSeconds: 20
{{- end }}
resources:
limits:
Expand Down Expand Up @@ -121,15 +122,15 @@ spec:
scheme: HTTP
initialDelaySeconds: 15
periodSeconds: 10
timeoutSeconds: 3
timeoutSeconds: 20
readinessProbe:
httpGet:
path: /viewer
port: 3000
scheme: HTTP
initialDelaySeconds: 15
periodSeconds: 10
timeoutSeconds: 3
timeoutSeconds: 20
resources:
limits:
memory: {{ .Values.registryViewer.memoryLimit }}
Expand All @@ -147,11 +148,6 @@ spec:
"fqdn": "{{ template "devfileregistry.ingressUrl" . }}"
}
]
volumeMounts:
- name: viewer-env-file
mountPath: /app/.env.production
subPath: .env.production
readOnly: true
securityContext:
allowPrivilegeEscalation: false
runAsNonRoot: true
Expand Down