Skip to content

Conversation

@michael-valdron
Copy link
Member

@michael-valdron michael-valdron commented Mar 11, 2024

Please specify the area for this PR

registry-library

What does does this PR do / why we need it:

Fixes issue with fetching latest revisions of registry library on consumers.

Which issue(s) this PR fixes:

Fixes #?

fixes devfile/api#1475

PR acceptance criteria:

  • Test Coverage
    • Are your changes sufficiently tested, and are any applicable test cases added or updated to cover your changes?

Documentation (WIP)

How to test changes / Special notes to the reviewer:

@codecov
Copy link

codecov bot commented Mar 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 27.23%. Comparing base (a61d432) to head (faef096).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #222   +/-   ##
=======================================
  Coverage   27.23%   27.23%           
=======================================
  Files           7        7           
  Lines        2012     2012           
=======================================
  Hits          548      548           
  Misses       1417     1417           
  Partials       47       47           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Michael Valdron <mvaldron@redhat.com>
Copy link
Contributor

@Jdubrick Jdubrick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Mar 11, 2024
@openshift-ci
Copy link

openshift-ci bot commented Mar 11, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Jdubrick, michael-valdron

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [Jdubrick,michael-valdron]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@michael-valdron michael-valdron merged commit e51ee89 into devfile:main Mar 11, 2024
michael-valdron added a commit to michael-valdron/devfile-registry-support that referenced this pull request Mar 11, 2024
Signed-off-by: Michael Valdron <mvaldron@redhat.com>
michael-valdron added a commit that referenced this pull request Mar 11, 2024
Signed-off-by: Michael Valdron <mvaldron@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Fetching registry library fails due to improper reference to index generator

2 participants