Skip to content

Conversation

@JslYoon
Copy link
Contributor

@JslYoon JslYoon commented Aug 4, 2025

Description of Changes

Updated go modules from 1.21/1.22 to 1.24:

Update registry-library/go.mod to Go 1.24

Update index/generator/go.mod to Go 1.24

Update index/server/go.mod to Go 1.24

Update tests/integration/go.mod to Go 1.24

Update index/server/Dockerfile to Go 1.24

Update oci-registry/Dockerfile to Go 1.24

Update tests/integration/Dockerfile to Go 1.24

Update .ci/Dockerfile to Go 1.24

Update .github/workflows/ci.yaml to Go 1.24

Update .github/workflows/codecov.yaml to Go 1.24

Update .github/workflows/pushimage-next.yaml to Go 1.24

Do code refactoring where needed

Update Go tag under README

Related Issue(s)

devfile/api#1710 && devfile/api#1700

Acceptance Criteria

Tests

  • [o] Test Coverage
    • Are your changes sufficiently tested, and are any applicable test cases added or updated to cover your changes?

@JslYoon JslYoon self-assigned this Aug 4, 2025
@JslYoon JslYoon force-pushed the JslYoon/updateGo1.24 branch from 3146a48 to 888bfad Compare August 4, 2025 18:56
@JslYoon JslYoon moved this to In Review 👀 in Devfile Project Aug 4, 2025
@JslYoon JslYoon force-pushed the JslYoon/updateGo1.24 branch from 888bfad to b195d99 Compare August 4, 2025 20:37
…ad artifact version

Signed-off-by: Lucas Yoon <lyoon@lyoon-thinkpadp1gen7.boston.csb>
@JslYoon JslYoon force-pushed the JslYoon/updateGo1.24 branch from b195d99 to 810fc26 Compare August 4, 2025 20:40
Copy link
Contributor

@thepetk thepetk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Aug 5, 2025
@openshift-ci
Copy link

openshift-ci bot commented Aug 5, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JslYoon, thepetk

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 5, 2025
@JslYoon
Copy link
Contributor Author

JslYoon commented Aug 5, 2025

Also addressed devfile/api#1707

@JslYoon JslYoon merged commit 7498ab6 into main Aug 5, 2025
17 checks passed
@JslYoon JslYoon deleted the JslYoon/updateGo1.24 branch August 5, 2025 17:46
@JslYoon JslYoon moved this from In Review 👀 to Done ✅ in Devfile Project Aug 18, 2025
@JslYoon
Copy link
Contributor Author

JslYoon commented Aug 18, 2025

Moving the go version to 1.23 @michael-valdron

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.

Projects

Status: Done ✅

Development

Successfully merging this pull request may close these issues.

3 participants