Skip to content

Conversation

@michael-valdron
Copy link
Member

Description of Changes

  • build_image.sh allows for alias docker=podman to be set if USE_PODMAN=true
  • bash build_image.sh <registry-content> 1 builds offline image
  • README for build-tools has been updated to mention Go 1.24 as requirement
  • update_devfiles_offline.sh script now allows STACKS_DIR to be overridden

Related Issue(s)

N/A

Acceptance Criteria

Tests

  • Test Coverage
    • Are your changes sufficiently tested, and are any applicable test cases added or updated to cover your changes?

Documentation

Tests Performed

Explain what tests you personally ran to ensure the changes are functioning as expected.

How To Test

Instructions for the reviewer on how to test your changes.

Run build-tools/build_image.sh script with different parameters given.

Examples:

  • bash build-tools/build_image.sh tests/registry - custom image build of test registry content
  • bash build-tools/build_image.sh tests/registry 1 - custom offline image build of test registry content

Notes To Reviewer

Any notes you would like to include for the reviewer.

Signed-off-by: Michael Valdron <mvaldron@redhat.com>
Signed-off-by: Michael Valdron <mvaldron@redhat.com>
@openshift-ci openshift-ci bot requested a review from elsony September 17, 2025 21:03
@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 17, 2025
Copy link
Contributor

@thepetk thepetk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Sep 18, 2025
@openshift-ci
Copy link

openshift-ci bot commented Sep 18, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: michael-valdron, thepetk

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [michael-valdron,thepetk]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@michael-valdron michael-valdron merged commit 6c0e450 into devfile:main Sep 18, 2025
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants