Skip to content

Conversation

thepetk
Copy link
Contributor

@thepetk thepetk commented Sep 11, 2025

Description of Changes

Adds a deprecated label to the old golang stacks (go version older than v1.23 and also skips them from renovate updates.

Related Issue(s)

N/A

Acceptance Criteria

  • Contributing guide

Have you read the devfile registry contributing guide and followed its instructions?

  • Test automation

Does this repository's tests pass with your changes?

  • Documentation

Does any documentation need to be updated with your changes?

  • Check Tools Provider

Have you tested the changes with existing tools, i.e. Odo, Che, Console? (See devfile registry contributing guide on how to test changes)

Tests Performed

Explain what tests you personally ran to ensure the changes are functioning as expected.

How To Test

Instructions for the reviewer on how to test your changes.

Notes To Reviewer

Any notes you would like to include for the reviewer.

@thepetk thepetk requested review from a team as code owners September 11, 2025 11:39
Copy link

openshift-ci bot commented Sep 11, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: thepetk

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@michael-valdron
Copy link
Member

/retest

3 similar comments
@thepetk
Copy link
Contributor Author

thepetk commented Sep 13, 2025

/retest

@michael-valdron
Copy link
Member

/retest

@thepetk
Copy link
Contributor Author

thepetk commented Oct 14, 2025

/retest

@thepetk thepetk force-pushed the feat/deprecate_go_stacks branch from 08959a0 to ae703d8 Compare October 15, 2025 13:47
@thepetk
Copy link
Contributor Author

thepetk commented Oct 15, 2025

@michael-valdron I've included my updates for the validate-samples workflow fix.

The action is currently failing for all PRs as we have a problem with the convertKubernetesContentInUri variable.

More specifically, after the #624 was merged, this check is now able to fetch correctly the paths, so it's able to recognize the related sample and tries to verify its schema.

Now as we haven't set convertKubernetesContentInUri := false the parser.ParserAgs tries to find kubernetes resrouces too, while they don't exist in the .zip file we are wroking with.

That said I'm adding this flag just to make it ignore looking for files like deploy.yaml and focus only on schema validation.

Signed-off-by: thepetk <thepetk@gmail.com>
Signed-off-by: thepetk <thepetk@gmail.com>
@thepetk thepetk force-pushed the feat/deprecate_go_stacks branch from ae703d8 to 0461f1e Compare October 15, 2025 14:03
@thepetk
Copy link
Contributor Author

thepetk commented Oct 15, 2025

Rebased to latest main

@thepetk
Copy link
Contributor Author

thepetk commented Oct 16, 2025

/retest

Copy link

openshift-ci bot commented Oct 16, 2025

@thepetk: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/v4.16-registry-test 0461f1e link true /test v4.16-registry-test

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants