-
Notifications
You must be signed in to change notification settings - Fork 93
Deprecate old go stacks #642
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: thepetk The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/retest |
3 similar comments
/retest |
/retest |
/retest |
08959a0
to
ae703d8
Compare
@michael-valdron I've included my updates for the The action is currently failing for all PRs as we have a problem with the More specifically, after the #624 was merged, this check is now able to fetch correctly the paths, so it's able to recognize the related sample and tries to verify its schema. Now as we haven't set That said I'm adding this flag just to make it ignore looking for files like |
Signed-off-by: thepetk <thepetk@gmail.com>
Signed-off-by: thepetk <thepetk@gmail.com>
ae703d8
to
0461f1e
Compare
Rebased to latest main |
/retest |
@thepetk: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
Description of Changes
Adds a
deprecated
label to the old golang stacks (go
version older thanv1.23
and also skips them from renovate updates.Related Issue(s)
N/A
Acceptance Criteria
Have you read the devfile registry contributing guide and followed its instructions?
Does this repository's tests pass with your changes?
Does any documentation need to be updated with your changes?
Have you tested the changes with existing tools, i.e. Odo, Che, Console? (See devfile registry contributing guide on how to test changes)
Tests Performed
Explain what tests you personally ran to ensure the changes are functioning as expected.
How To Test
Instructions for the reviewer on how to test your changes.
Notes To Reviewer
Any notes you would like to include for the reviewer.