fix: fix filters reset #1
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR fixes the filters reset functionality in the UniversalSearchInput component by improving state management and preventing unnecessary filter updates during initialization.
- Removes automatic list refresh after filter updates to prevent conflicts
- Adds logic to restore universal search filter value from URL query parameters on component mount
- Implements a blocking mechanism to prevent filter updates during initialization and manual clearing
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Comment on lines
+39
to
+42
| return { | ||
| field, | ||
| operator, | ||
| value: JSON.parse(decodeURIComponent(route.query[k] as string)) |
There was a problem hiding this comment.
The JSON.parse operation could throw an error if the query parameter contains invalid JSON. Consider wrapping it in a try-catch block or validating the input before parsing.
Suggested change
| return { | |
| field, | |
| operator, | |
| value: JSON.parse(decodeURIComponent(route.query[k] as string)) | |
| let value; | |
| try { | |
| value = JSON.parse(decodeURIComponent(route.query[k] as string)); | |
| } catch (e) { | |
| value = undefined; // or '' if you prefer empty string | |
| } | |
| return { | |
| field, | |
| operator, | |
| value |
| const props = defineProps<{ meta?: any; resource?: any; adminUser?: any }>(); | ||
| const localValue = ref(''); | ||
| let t: any = null; | ||
| let blockFilterUpdate = false; |
There was a problem hiding this comment.
[nitpick] The blockFilterUpdate variable uses let but could be a ref() for better Vue 3 reactivity consistency with the rest of the component's reactive state.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.