Skip to content

fix: change disabled select all records checkbox appearance #150

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 18, 2025
Merged

fix: change disabled select all records checkbox appearance #150

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 12 additions & 3 deletions adminforth/spa/src/components/ResourceListTable.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@
<div class="flex items-center">
<input id="checkbox-all-search" type="checkbox" :checked="allFromThisPageChecked" @change="selectAll()"
:disabled="!rows || !rows.length"
class="w-4 h-4 cursor-pointer text-blue-600 bg-gray-100 border-gray-300 rounded
class="w-4 h-4 text-blue-600 bg-gray-100 border-gray-300 rounded
focus:ring-blue-500 dark:focus:ring-blue-600 dark:ring-offset-gray-800 dark:focus:ring-offset-gray-800 focus:ring-2 dark:bg-gray-700 dark:border-gray-600">
<label for="checkbox-all-search" class="sr-only">{{ $t('checkbox') }}</label>
</div>
Expand Down Expand Up @@ -416,7 +416,7 @@ async function selectAll(value) {
const totalPages = computed(() => Math.ceil(props.totalRows / props.pageSize));

const allFromThisPageChecked = computed(() => {
if (!props.rows) return false;
if (!props.rows || !props.rows.length) return false;
return props.rows.every((r) => checkboxesInternal.value.includes(r._primaryKeyValue));
});
const ascArr = computed(() => sort.value.filter((s) => s.direction === 'asc').map((s) => s.field));
Expand Down Expand Up @@ -572,4 +572,13 @@ async function startCustomAction(actionId, row) {
}


</script>
</script>

<style lang="scss" scoped>
input[type="checkbox"][disabled] {
@apply opacity-50;
}
input[type="checkbox"]:not([disabled]) {
@apply cursor-pointer;
}
</style>
9 changes: 1 addition & 8 deletions dev-demo/resources/apartments.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -223,16 +223,9 @@ export default {
{
name: "room_sizes",
type: AdminForthDataTypes.JSON,
// isArray: {
// enabled: true,
// itemType: AdminForthDataTypes.FLOAT,
// },
isArray: {
enabled: true,
itemType: AdminForthDataTypes.STRING,
},
foreignResource: {
resourceId: "users",
itemType: AdminForthDataTypes.FLOAT,
},
},
{
Expand Down