AMP-30706 - Global partnership reports not loads #4114
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix tooltips to reports work
Fix tooltips to reports work. Commit 2
jdeanquin-dg
requested changes
Sep 14, 2023
| const fiscalYear = translatedFY ? translatedFY : Constants.FY; | ||
| const cal = calendars.filter( calendar => calendar.id == Utils.getCalendarId(settingsWidget) )[0]; | ||
| return cal.isFiscal ? fiscalYear + ' ' : ''; | ||
| return cal['is-fiscal'] ? fiscalYear + ' ' : ''; |
Contributor
There was a problem hiding this comment.
Add this string to the constants file, please.
Add constant to refer to calendar's property
jdeanquin-dg
approved these changes
Sep 19, 2023
jdeanquin-dg
merged commit 34a8806
into
feature/AMP-30620/migrate-spring-jersey-hibernate
jdeanquin-dg
deleted the
issue/AMP-30706/Global-partnership-reports-not-loads
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix tooltips to reports work