Fix: Invalid messages with too many plots #21
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This saves some memory since concatenating Strings means copying. Also see Issue devinaconley#20
This is also to save some memory. See Issue devinaconley#20
devinaconley
requested changes
Jul 25, 2018
Owner
devinaconley
left a comment
devinaconley
left a comment
There was a problem hiding this comment.
Looks good, thanks.
Just a style comment, can you add spaces into method calls?
Contributor
Author
|
I'm not quite sure what you mean by that - do you mean separating the print-statements into several lines? |
plotter/Plotter.cpp
Outdated
| bool config = counter == 0; | ||
|
|
||
| Serial.print( "{\"" + TIME_KEY + "\":" ); Serial.print( millis() ); | ||
| Serial.print( "{\""); Serial.print(TIME_KEY); Serial.print("\":" ); Serial.print( millis() ); |
Owner
There was a problem hiding this comment.
@Chritzel - for example this line would be:
Serial.print( "{\"" ); Serial.print( TIME_KEY ); Serial.print( "\":" ); Serial.print( millis() );
As discussed in PR devinaconley#21
Contributor
Author
|
Don't know if you saw this, I added two commits fixing the style :) |
Owner
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the PR to Issue #20