Fix: Update Document ID to be a string #1
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Typesense actually expects IDs to be Strings - and this is necessary to handle UUIDs in schema
AbdullahFaqeir
approved these changes
May 5, 2020
Contributor
AbdullahFaqeir
left a comment
AbdullahFaqeir
left a comment
There was a problem hiding this comment.
Hello Matthew,
Thanks for you PR and your time, much appreciated.
Contributor
Author
|
Thanks @AbdullahFaqeir ! If you can tag a new release it would be very appreciated! |
Contributor
|
@matthewhall-ca of course, consider it done, thanks again. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Typesense actually expects IDs to be Strings - and this is necessary to handle UUIDs in schema