feat: add ESM build support with dual CommonJS/ESM exports #194
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add separate TypeScript configs for ESM and CommonJS builds - Configure package.json with proper dual exports - Add build script to fix ESM imports with .js extensions - Support both import and require syntax - Add CONTRIBUTING.md with contribution guidelines
|
🎉 This PR is included in version 1.3.0-beta.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
|
🎉 This PR is included in version 1.3.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
|
🎉 This PR is included in version 1.3.0-beta.2 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Changes
tsconfig.esm.json) and CommonJS (tsconfig.cjs.json) buildsmodulefield pointing to ESM build.jsextensionsdist/cjs/- CommonJS build with type markerdist/esm/- ESM build with type markerTest Plan
yarn buildimport { Configuration } from '@devmehq/sdk-js'const { Configuration } = require('@devmehq/sdk-js')