Update dependencies and enhance logging in authentication process #174
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
devondragon
commented
Apr 6, 2025
devondragon
commented
- Bump Lombok version from 1.18.36 to 1.18.38
- Update Gradle wrapper to version 8.13
- Refactor DSUserDetails class to remove OAuth2User interface
- Enhance logging in LoginSuccessService for better request tracking
- Comment out update password test in UserApiTest due to dependency issues
- Create Response class file
- Bump Lombok version from 1.18.36 to 1.18.38 - Update Gradle wrapper to version 8.13 - Refactor DSUserDetails class to remove OAuth2User interface - Enhance logging in LoginSuccessService for better request tracking - Comment out update password test in UserApiTest due to dependency issues - Create Response class file
Contributor
There was a problem hiding this comment.
Copilot reviewed 5 out of 6 changed files in this pull request and generated no comments.
Files not reviewed (1)
- gradle/wrapper/gradle-wrapper.properties: Language not supported
Comments suppressed due to low confidence (1)
src/main/java/com/digitalsanctuary/spring/user/service/LoginSuccessService.java:47
- There is a minor typo in the log message: 'authentiation' should be corrected to 'authentication' for clarity.
log.debug("LoginSuccessService.onAuthenticationSuccess:" + "called with authentiation: {}", authentication);
devondragon
deleted the
issue-173-BUG---Login-with-Google-SSO-Causes-Error
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.