Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#31: introduce devon CLI with plugable commands, increase UX, reduce script confusion #32

Merged
merged 29 commits into from
Mar 11, 2019
Merged

#31: introduce devon CLI with plugable commands, increase UX, reduce script confusion #32

merged 29 commits into from
Mar 11, 2019

Conversation

hohwille
Copy link
Member

@hohwille hohwille commented Feb 15, 2019

This PR implements #31 improves OS support (#25) and also fixes the following issues:

@hohwille
Copy link
Member Author

This PR is introducing 3rd party libs for ide-configurator.
IMHO we should avoid using maven-shade-plugin or maven-assembly-plugin to generate a fat jar as this has some license implications. Then the JAR contains a mixture of classes from different vendors and with different licenses. Instead we should keep the ide-configurator JAR free from 3rd party classes and simply add these as their original JARs to the scripts package release. There we can include a TERMS_OF_USE and/or LICENSE file explaining the used licenses. Downloading and including the relevant licenses could be automated with the license-maven-plugin

@hohwille hohwille changed the title #31: redesign (WIP / Preview) #31: introduce devon CLI with plugable commands, increase UX, reduce script confusion Mar 5, 2019
@hohwille
Copy link
Member Author

hohwille commented Mar 5, 2019

To complete this I see the following aspects:

  • remove further console variant scripts for windows
  • create a command plugin for opening console windows for different OS and types (devon console or devon console cygwin/devon cygwin, ...)
  • Add a setup script in the toplevel directory that can be double clicked. What would people expect? Should it also open the IDE (IMHO no) or just setup? Should we still create eclipse-* and vscode-* scripts by default? Or will all users pickup the new CLI approach? IMHO to catch up with our large user-base the toplevel script should create the IDE launch scripts for the main workspace automatically. Then we will have less questions. People can still delete the scripts and use CLI only if they like.
  • Adopt IDE scripts to create *.bat files to launch IDE on windows instead of bash scripts (5 minutes of work).
  • Integrate devcon?
  • Add lots of documentation...

@hohwille hohwille added this to the release:3.0.0 milestone Mar 11, 2019
@hohwille hohwille added enhancement New feature or request linux specific for linux OS (debian, ubunutu, suse, etc.) macOS specific for Apple MacOS windows specific for Microsoft Windows OS scripts related to shell scripts (bash and CMD) settings ide-settings repo and replated processes and features software software-package with 3rd party products labels Mar 11, 2019
@hohwille hohwille merged commit 0c98570 into devonfw:master Mar 11, 2019
@hohwille hohwille linked an issue Jan 6, 2022 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request linux specific for linux OS (debian, ubunutu, suse, etc.) macOS specific for Apple MacOS scripts related to shell scripts (bash and CMD) settings ide-settings repo and replated processes and features software software-package with 3rd party products windows specific for Microsoft Windows OS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

redesign, reduce scripts, increase UX
1 participant