Skip to content

feature: improve error logging #15

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 19, 2020
Merged

feature: improve error logging #15

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7d84437
chore: improve error logging in intercom provider
devrnt May 19, 2020
48b26b5
Merge pull request #14 from devrnt/feature/error-handling
devrnt May 19, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions src/provider.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@ import { IntercomContextValues, IntercomProviderProps } from './contextTypes';
import { IntercomAPI } from './intercom';
import { IntercomProps, RawIntercomBootProps } from './types';
import { mapIntercomPropsToRawIntercomProps } from './mappers';
import { isEmptyObject } from './utils';

export const IntercomProvider = ({
appId,
Expand All @@ -15,7 +16,17 @@ export const IntercomProvider = ({
onHide,
onShow,
onUnreadCountChange,
...rest
}: IntercomProviderProps) => {
if (!isEmptyObject(rest))
logger.log(
'error',
[
'some invalid props were passed to IntercomProvider. ',
`Please check following props: ${Object.keys(rest).join(', ')}.`,
].join(''),
);

const [isBooted, setIsBooted] = useState(autoBoot);

if (!window.Intercom) {
Expand Down
2 changes: 2 additions & 0 deletions src/utils.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
export const isEmptyObject = (obj: object) =>
Object.keys(obj).length === 0 && obj.constructor === Object;