Skip to content

Conversation

@devrnt
Copy link
Owner

@devrnt devrnt commented May 21, 2020

Resolves issue where custom attributes were not passed to Intercom.

  • Add "super-seeded" boot in playground
  • Add mapping tests, camel cased attributes should correctly be passed to Intercom. E.g. appId to app_id, verticalPadding to vertical_padding...
  • Update IntercomProps to receive a customAttributes prop. This is an object with all the raw custom attribute key-value entries.

Fixes #16,
Fixes #17

@devrnt devrnt self-assigned this May 21, 2020
@github-actions
Copy link
Contributor

Size Change: +60 B (0%)

Total Size: 9.35 kB

Filename Size Change
dist/react-use-intercom.cjs.development.js 3.53 kB +18 B (0%)
dist/react-use-intercom.cjs.production.min.js 2.25 kB +24 B (1%)
dist/react-use-intercom.esm.js 3.42 kB +18 B (0%)
ℹ️ View Unchanged
Filename Size Change
dist/index.js 152 B 0 B

compressed-size-action

@devrnt devrnt merged commit a016397 into master May 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Bug: custom variables do not work Cannot use snake cased args (for non-custom Intercom props)

1 participant