Skip to content

refactor: use react namespace imports #25

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Parent: feature: upgrade testing-library and typescript
merged 3 commits into from
May 24, 2020
Merged

refactor: use react namespace imports #25

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
efebea3
chore: update tsconfig
devrnt May 24, 2020
d8e2ad0
refactor: use react namespace imports
devrnt May 24, 2020
9ebed3a
refactor: use namespace imports in config
devrnt May 24, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions config/test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
import dotenv from 'dotenv';
import path from 'path';
import * as dotenv from 'dotenv';
import * as path from 'path';
import { Config } from '.';

if (!process.env.CI) {
Expand Down
4 changes: 2 additions & 2 deletions src/context.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,12 +1,12 @@
import { createContext } from 'react';
import * as React from 'react';

import * as logger from './logger';
import { IntercomContextValues } from './contextTypes';

const NO_INTERCOM_PROVIDER_MESSAGE =
'Please wrap your component with `IntercomProvider`.';

const IntercomContext = createContext<IntercomContextValues>({
const IntercomContext = React.createContext<IntercomContextValues>({
boot: () => logger.log('error', NO_INTERCOM_PROVIDER_MESSAGE),
shutdown: () => logger.log('error', NO_INTERCOM_PROVIDER_MESSAGE),
hardShutdown: () => logger.log('error', NO_INTERCOM_PROVIDER_MESSAGE),
Expand Down
36 changes: 18 additions & 18 deletions src/provider.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import React, { useContext, useCallback, useMemo, useState } from 'react';
import * as React from 'react';

import * as logger from './logger';
import initialize from './initialize';
Expand Down Expand Up @@ -27,7 +27,7 @@ export const IntercomProvider = ({
].join(''),
);

const [isBooted, setIsBooted] = useState(autoBoot);
const [isBooted, setIsBooted] = React.useState(autoBoot);

if (!window.Intercom) {
initialize(appId);
Expand All @@ -43,7 +43,7 @@ export const IntercomProvider = ({
}
}

const ensureIntercomIsBooted = useCallback(
const ensureIntercomIsBooted = React.useCallback(
(functionName: string = 'A function', callback: Function) => {
if (!isBooted) {
logger.log(
Expand All @@ -61,7 +61,7 @@ export const IntercomProvider = ({
[isBooted],
);

const boot = useCallback(
const boot = React.useCallback(
(props?: IntercomProps) => {
if (isBooted) return;

Expand All @@ -77,14 +77,14 @@ export const IntercomProvider = ({
[appId, isBooted],
);

const shutdown = useCallback(() => {
const shutdown = React.useCallback(() => {
if (!isBooted) return;

IntercomAPI('shutdown');
setIsBooted(false);
}, [isBooted]);

const hardShutdown = useCallback(() => {
const hardShutdown = React.useCallback(() => {
if (!isBooted) return;

IntercomAPI('shutdown');
Expand All @@ -93,14 +93,14 @@ export const IntercomProvider = ({
setIsBooted(false);
}, [isBooted]);

const refresh = useCallback(() => {
const refresh = React.useCallback(() => {
ensureIntercomIsBooted('update', () => {
const lastRequestedAt = new Date().getTime();
IntercomAPI('update', { last_requested_at: lastRequestedAt });
});
}, [ensureIntercomIsBooted]);

const update = useCallback(
const update = React.useCallback(
(props?: IntercomProps) => {
ensureIntercomIsBooted('update', () => {
if (!props) {
Expand All @@ -115,23 +115,23 @@ export const IntercomProvider = ({
[ensureIntercomIsBooted, refresh],
);

const hide = useCallback(() => {
const hide = React.useCallback(() => {
ensureIntercomIsBooted('hide', () => {
IntercomAPI('hide');
});
}, [ensureIntercomIsBooted]);

const show = useCallback(() => {
const show = React.useCallback(() => {
ensureIntercomIsBooted('show', () => IntercomAPI('show'));
}, [ensureIntercomIsBooted]);

const showMessages = useCallback(() => {
const showMessages = React.useCallback(() => {
ensureIntercomIsBooted('showMessages', () => {
IntercomAPI('showMessages');
});
}, [ensureIntercomIsBooted]);

const showNewMessages = useCallback(
const showNewMessages = React.useCallback(
(message?: string) => {
ensureIntercomIsBooted('showNewMessage', () => {
if (!message) {
Expand All @@ -144,13 +144,13 @@ export const IntercomProvider = ({
[ensureIntercomIsBooted],
);

const getVisitorId = useCallback(() => {
const getVisitorId = React.useCallback(() => {
return ensureIntercomIsBooted('getVisitorId', () => {
return (IntercomAPI('getVisitorId') as unknown) as string;
});
}, [ensureIntercomIsBooted]);

const startTour = useCallback(
const startTour = React.useCallback(
(tourId: number) => {
ensureIntercomIsBooted('startTour', () => {
IntercomAPI('startTour', tourId);
Expand All @@ -159,7 +159,7 @@ export const IntercomProvider = ({
[ensureIntercomIsBooted],
);

const trackEvent = useCallback(
const trackEvent = React.useCallback(
(event: string, metaData?: object) => {
ensureIntercomIsBooted('trackEvent', () => {
if (metaData) {
Expand All @@ -172,7 +172,7 @@ export const IntercomProvider = ({
[ensureIntercomIsBooted],
);

const providerValue = useMemo<IntercomContextValues>(() => {
const providerValue = React.useMemo<IntercomContextValues>(() => {
return {
boot,
shutdown,
Expand Down Expand Up @@ -200,7 +200,7 @@ export const IntercomProvider = ({
trackEvent,
]);

const content = useMemo(() => children, [children]);
const content = React.useMemo(() => children, [children]);

return (
<IntercomContext.Provider value={providerValue}>
Expand All @@ -209,4 +209,4 @@ export const IntercomProvider = ({
);
};

export const useIntercomContext = () => useContext(IntercomContext);
export const useIntercomContext = () => React.useContext(IntercomContext);
3 changes: 2 additions & 1 deletion tsconfig.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,7 @@
"*": ["src/*", "node_modules/*"]
},
"jsx": "react",
"esModuleInterop": true
"esModuleInterop": true,
"allowSyntheticDefaultImports": false,
}
}