fix: do ensureNamespace only if the namespace doesn't really exist. #2604
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for devspace-docs canceled.Built without sensitive environment variables
|
Signed-off-by: Luca Di Maio <luca.dimaio1@gmail.com>
lizardruss
reviewed
Mar 21, 2023
Signed-off-by: Luca Di Maio <luca.dimaio1@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
/kind bugfix
resolves #2603
Closes ENG-1154
Fixed an issue where DevSpace would attempt to create the namespace for localregistry even it the namespace indeed exists.
This came out as a problem in the moment the user wasn't authorized to create namespaces, thus checking before leaping now.