Skip to content

chore: upgrade component-chart to 0.8.6 #2606

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 21, 2023
Merged

chore: upgrade component-chart to 0.8.6 #2606

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions e2e/tests/localregistry/testdata/local-registry-kubectl/manifests/deployment.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ metadata:
"app.kubernetes.io/component": "app"
"app.kubernetes.io/managed-by": "Helm"
annotations:
"helm.sh/chart": "component-chart-0.8.5"
"helm.sh/chart": "component-chart-0.8.6"
spec:
replicas: 1
strategy:
Expand All @@ -24,7 +24,7 @@ spec:
"app.kubernetes.io/component": "app"
"app.kubernetes.io/managed-by": "Helm"
annotations:
"helm.sh/chart": "component-chart-0.8.5"
"helm.sh/chart": "component-chart-0.8.6"
spec:
imagePullSecrets:
nodeSelector:
Expand Down
14 changes: 11 additions & 3 deletions e2e/tests/render/render.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,12 +2,13 @@ package render

import (
"bytes"
"github.com/onsi/ginkgo/v2"
"os"
"path/filepath"
"strings"
"sync"

"github.com/onsi/ginkgo/v2"

"github.com/loft-sh/devspace/cmd"
"github.com/loft-sh/devspace/cmd/flags"
"github.com/loft-sh/devspace/e2e/framework"
Expand Down Expand Up @@ -49,7 +50,11 @@ var _ = DevSpaceDescribe("build", func() {
err = renderCmd.RunDefault(f)
framework.ExpectNoError(err)
content := strings.TrimSpace(stdout.String()) + "\n"
framework.ExpectLocalFileContentsImmediately(filepath.Join(tempDir, "rendered.txt"), content)

framework.ExpectLocalFileContentsImmediately(
filepath.Join(tempDir, "rendered.txt"),
content,
)
})

ginkgo.It("should render kubectl deployments", func() {
Expand All @@ -71,7 +76,10 @@ var _ = DevSpaceDescribe("build", func() {
err = renderCmd.RunDefault(f)
framework.ExpectNoError(err)
content := strings.TrimSpace(stdout.String()) + "\n"
framework.ExpectLocalFileContentsImmediately(filepath.Join(tempDir, "rendered.txt"), content)
framework.ExpectLocalFileContentsImmediately(
filepath.Join(tempDir, "rendered.txt"),
content,
)
})
})

Expand Down
7 changes: 5 additions & 2 deletions e2e/tests/render/testdata/helm/rendered.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ metadata:
"app.kubernetes.io/component": "test"
"app.kubernetes.io/managed-by": "Helm"
annotations:
"helm.sh/chart": "component-chart-0.8.5"
"helm.sh/chart": "component-chart-0.8.6"
spec:
replicas: 1
strategy:
Expand All @@ -26,7 +26,7 @@ spec:
"app.kubernetes.io/component": "test"
"app.kubernetes.io/managed-by": "Helm"
annotations:
"helm.sh/chart": "component-chart-0.8.5"
"helm.sh/chart": "component-chart-0.8.6"
spec:
imagePullSecrets:
nodeSelector:
Expand Down Expand Up @@ -82,3 +82,6 @@ spec:
---
# Source: component-chart/templates/deployment.yaml
# Create headless service for StatefulSet
---
# Source: component-chart/templates/ingress.yaml
#
2 changes: 1 addition & 1 deletion pkg/devspace/deploy/deployer/helm/client.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ const ComponentChartFolder = "component-chart"
// DevSpaceChartConfig is the config that holds the devspace chart information
var DevSpaceChartConfig = &latest.ChartConfig{
Name: "component-chart",
Version: "0.8.5",
Version: "0.8.6",
RepoURL: "https://charts.devspace.sh",
}

Expand Down