refactor: replace for loop with map in topologicalSortChangesInBatch #878
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: homily707 <homily707@outlook.com>
iyear
approved these changes
Jul 21, 2022
Member
iyear
left a comment
iyear
left a comment
There was a problem hiding this comment.
Nice refactoring! Reduces a large number of ineffective loop.
IronCore864
approved these changes
Jul 21, 2022
Member
|
Good job! @homily707 👏 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: homily707 homily707@outlook.com
Pre-Checklist
Note: please complete ALL items in the following checklist.
Description
replace for loop with map in topologicalSortChangesInBatch
Related Issues
no
New Behavior (screenshots if needed)