feat: pkg/util/github/release enhancement(sub task of pkg/util Enhancement #833) #886
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: xian-jie.shen <327411586@qq.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: xian-jie.shen 327411586@qq.com
Pre-Checklist
Note: please complete ALL items in the following checklist.
Description
Try to mock an HTTP server for testing github client API(inspired by go-github client's test case), the delta codes of this testing API method are a little bit more than before, so this pr is just given it a try.
Related Issues
see #833 for the details
New Behavior (screenshots if needed)
the ut of
releaseby calling a local mock server