Skip to content

Conversation

@jxs1211
Copy link

@jxs1211 jxs1211 commented Jul 23, 2022

Signed-off-by: xian-jie.shen 327411586@qq.com

Pre-Checklist

Note: please complete ALL items in the following checklist.

  • I have read through the CONTRIBUTING.md documentation.
  • My code has the necessary comments and documentation (if needed).
  • I have added relevant tests

Description

add ut for pkg/util/github/branch

Related Issues

see #833 for the details

New Behavior (screenshots if needed)

[going@dev github]$ go tool cover -func=coverage.out
github.com/devstream-io/devstream/pkg/util/github/branch.go:11:                 NewBranch                               100.0%
github.com/devstream-io/devstream/pkg/util/github/branch.go:38:                 DeleteBranch                            100.0%
github.com/devstream-io/devstream/pkg/util/github/commit.go:11:                 GetLastCommit                           0.0%

Signed-off-by: xian-jie.shen <327411586@qq.com>
@jxs1211 jxs1211 requested a review from a team as a code owner July 23, 2022 04:13
Copy link
Member

@daniel-hutao daniel-hutao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution! UT work is important. I'll approve this pr in no time, but I still have a tip for you: try to use the ginkgo framework to write UT, it will be much easier.

@IronCore864 IronCore864 merged commit 7b7f469 into devstream-io:main Jul 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants