Skip to content

feat: plugin scaffolding refactor #906

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
IronCore864 merged 7 commits into from
Jul 28, 2022
Merged

feat: plugin scaffolding refactor #906

IronCore864 merged 7 commits into from
Jul 28, 2022

Conversation

@steinliber
Copy link

@steinliber steinliber commented Jul 25, 2022 •
edited
Loading

Pre-Checklist

Note: please complete ALL items in the following checklist.

  • I have read through the CONTRIBUTING.md documentation.
  • My code has the necessary comments and documentation (if needed).
  • I have added relevant tests

Description

  • Add gitlab support for repo-scaffolding.
  • Remove existing scaffolding plugins for specific languages, including Github and GitLab.
  • Update quickstart and gitops documentation and test it locally.
  • Update the list of supported plugins doc.

Related Issues

#850

New Behavior (screenshots if needed)

  • Delete github-repo-scaffolding-golang plugin.
  • Delete gitlab-repo-scaffolding-golang plugin.

@steinliber
feat: scaffolding support gitlab
b61702c 
Signed-off-by: Meng JiaFeng <jiafeng.meng@merico.dev>
@steinliber
fix: example gitops error
3b0268b 
Signed-off-by: Meng JiaFeng <jiafeng.meng@merico.dev>
@steinliber
fix: doc error
eb9fdb2 
Signed-off-by: Meng JiaFeng <jiafeng.meng@merico.dev>
@steinliber steinliber requested review from a team and IronCore864 as code owners July 25, 2022 15:46
iyear
iyear reviewed Jul 26, 2022
View reviewed changes
iyear
iyear approved these changes Jul 26, 2022
View reviewed changes
Copy link
Member

@iyear iyear left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A powerful plugin!

@iyear
Copy link
Member

iyear commented Jul 26, 2022

Does this plugin pass the test locally?

iyear
iyear reviewed Jul 26, 2022
View reviewed changes
@steinliber
fix: doc update, gitlab error fix
9c4caae 
Signed-off-by: Meng JiaFeng <jiafeng.meng@merico.dev>
@steinliber
Copy link
Author

steinliber commented Jul 26, 2022

Does this plugin pass the test locally?

I have tested this locally.

iyear
iyear reviewed Jul 26, 2022
View reviewed changes
@steinliber
fix: src repo and dst repo all support repo_type
02f4c88 
Signed-off-by: Meng JiaFeng <jiafeng.meng@merico.dev>
iyear
iyear reviewed Jul 26, 2022
View reviewed changes
@steinliber
fix: src repo type error
4b0efc8 
Signed-off-by: Meng JiaFeng <jiafeng.meng@merico.dev>
@IronCore864 IronCore864 merged commit d34aa84 into devstream-io:main Jul 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@IronCore864 IronCore864 IronCore864 approved these changes

@iyear iyear iyear approved these changes

Assignees

@IronCore864 IronCore864

@iyear iyear

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@steinliber @iyear @IronCore864