feat:pkg/util/gitHub/download enhancement #909
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jxs1211
force-pushed
the
feat-pkg-util-github-download
branch
from
4e0c37f to
f35a793
Compare
Member
|
@jxs1211 Many thanks for your test! Please fix the redundant commits~ |
jxs1211
force-pushed
the
feat-pkg-util-github-download
branch
from
f35a793 to
a9cb764
Compare
Author
done |
aFlyBird0
reviewed
Jul 28, 2022
aFlyBird0
reviewed
Jul 28, 2022
Member
|
I have checked the format of the test, could you please check the content of the test? Thanks! @HXCGIT |
Member
|
@jxs1211 Please remember to resolve the conflicts. 🙌 |
Signed-off-by: xian-jie.shen <327411586@qq.com>
jxs1211
force-pushed
the
feat-pkg-util-github-download
branch
from
a9cb764 to
d3149cf
Compare
Author
|
xavier-hou
approved these changes
Aug 1, 2022
Member
|
@jxs1211 Nice test! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pre-Checklist
Note: Please complete ALL items in the following checklist.
Description
add ut for download
Related Issues
see #833 for the details
New Behavior (screenshots if needed)
github.com/devstream-io/devstream/pkg/util/github/download.go:14: DownloadAsset 100.0%
github.com/devstream-io/devstream/pkg/util/github/download.go:83: DownloadLatestCodeAsZipFile 100.0%