Skip to content

Conversation

@aFlyBird0
Copy link
Member

@aFlyBird0 aFlyBird0 commented Aug 1, 2022

Signed-off-by: Bird aflybird0@gmail.com

Pre-Checklist

Note: please complete ALL items in the following checklist.

  • I have read through the CONTRIBUTING.md documentation.
  • My code has the necessary comments and documentation (if needed).
  • I have added relevant tests

Description

A new installer which can install docker.

Related Issues

#881

New Behavior (screenshots if needed)

image

image

image

Signed-off-by: Bird <aflybird0@gmail.com>
Copy link

@steinliber steinliber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@aFlyBird0 aFlyBird0 requested a review from daniel-hutao August 2, 2022 09:30
@aFlyBird0 aFlyBird0 marked this pull request as ready for review August 2, 2022 09:30
@aFlyBird0 aFlyBird0 requested a review from a team as a code owner August 2, 2022 09:30
Signed-off-by: Bird <aflybird0@gmail.com>
Copy link
Member

@iyear iyear left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome!

Signed-off-by: Bird <aflybird0@gmail.com>
@daniel-hutao daniel-hutao merged commit 2e99ac2 into devstream-io:main Aug 3, 2022
@aFlyBird0 aFlyBird0 deleted the docker-installer branch August 5, 2022 05:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants