Drop function transform#693
Merged
Merged
Conversation
gregtatum
force-pushed
the
drop-function
branch
from
e6fd10a to
cb31522
Compare
Codecov Report
@@ Coverage Diff @@
## master #693 +/- ##
==========================================
+ Coverage 62.31% 62.44% +0.12%
==========================================
Files 118 118
Lines 7046 7064 +18
Branches 1590 1596 +6
==========================================
+ Hits 4391 4411 +20
+ Misses 2335 2333 -2
Partials 320 320
Continue to review full report at Codecov.
|
mstange
approved these changes
Jan 4, 2018
| const { stackTable, frameTable, samples } = thread; | ||
|
|
||
| // Go through each stack, and label it as containing the function or not. | ||
| const stackContainsFunc = new Set(); |
Contributor
There was a problem hiding this comment.
I wonder if an array of booleans would be faster here. Would require less hashing.
Member
Author
There was a problem hiding this comment.
Ah good point, I'll make that change.
gregtatum
force-pushed
the
drop-function
branch
from
cb31522 to
7ef0f67
Compare
gregtatum
force-pushed
the
drop-function
branch
from
7ef0f67 to
74964d7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #220
This came out of discussions in #435.
This adds the ability to remove samples from the call tree. I called it "Drop functions".
Here I dropped idling from the compositor thread:
Here is the icon I created for "drop":
