feat: utils for command bar #854
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…common-lib into fix/trigger-view
…common-lib into fix/trigger-view
…custom 404 handling
…common-lib into fix/trigger-view
…package.json and package-lock.json
…common-lib into fix/trigger-view
….json and package-lock.json
…oymentConfigDiffRadioSelect
into chore/misc-fixes # Please enter a commit message to explain why this merge is necessary, # especially if it merges an updated upstream into a topic branch. # # Lines starting with '#' will be ignored, and an empty message aborts # the commit.
refactor: misc fixes
…ib into feat/resource-watcher-ui
feat: misc improvements
…common-lib into fix/bulk-deploy-trigger
feat: resource watcher UI
…ib into fix/resource-watcher-ui
fix: resource watcher UI
AbhishekA1509
requested review from
vikramdevtron and
vivek-devtron
as code owners
…Actions and refactor UserPathValueMapType
There was a problem hiding this comment.
Pull Request Overview
Adds utility components and types for implementing a command bar feature with navigation shortcuts and preferences management.
- Adds navigation item ID types for command bar functionality
- Creates KeyboardShortcut component to display keyboard keys
- Refactors focus trap and backdrop components to use keyboard shortcut hooks
Reviewed Changes
Copilot reviewed 13 out of 13 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| src/Shared/Hooks/useUserPreferences/types.ts | Adds navigation ID types and command bar preferences structure |
| src/Shared/Hooks/useUserPreferences/service.ts | Updates service to handle command bar preferences |
| src/Shared/Components/index.ts | Exports new KeyboardShortcut component |
| src/Shared/Components/KeyboardShortcut/ | New component to render keyboard shortcut indicators |
| src/Shared/Components/DTFocusTrap/ | Removes onEscape prop in favor of centralized shortcut handling |
| src/Shared/Components/Backdrop/ | Integrates keyboard shortcut registration for escape handling |
| src/Common/Types.ts | Removes deprecated signal option comment |
| src/Common/Hooks/UseRegisterShortcut/ | Adds '>' key to keyboard map and exports types |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
You can also share your feedback on Copilot code review for a chance to win a $100 gift card. Take the survey.
src/Shared/Components/KeyboardShortcut/KeyboardShortcut.component.tsx
Outdated
Show resolved
Hide resolved
RohitRaj011
reviewed
Aug 13, 2025
RohitRaj011
approved these changes
Aug 13, 2025
…common-lib into fix/bulk-deploy-trigger
feat: add api options in service
vivek-devtron
approved these changes
Aug 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds utility components and types for implementing a command bar feature with navigation shortcuts and preferences management.
Type of change
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Checklist