DOC: Broken images fixed in user-access.md file #654
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
prakarsh-dt
reviewed
Aug 27, 2021
| | `servicePort` | service port for the container | | ||
| | `envoyPort` | envoy port for the container. | | ||
| | `idleTimeout` | the duration of time that a connection is idle before the connection is terminated. | | ||
| | `name` | name of the container. | |
Collaborator
There was a problem hiding this comment.
Name of the port not container
prakarsh-dt
reviewed
Aug 27, 2021
| | `idleTimeout` | the duration of time that a connection is idle before the connection is terminated. | | ||
| | `name` | name of the container. | | ||
| | `port` | port for the container. | | ||
| | `servicePort` | service port for the container. | |
Collaborator
There was a problem hiding this comment.
Port of the corresponding kubernetes service
prakarsh-dt
reviewed
Aug 27, 2021
| | `port` | port for the container. | | ||
| | `servicePort` | service port for the container. | | ||
| | `supportStreaming` | Used for high performance protocols like grpc where timeout needs to be disabled. | | ||
| | `useHTTP2` | container can accept HTTP2 requests. | |
Collaborator
There was a problem hiding this comment.
Envoy container can accept HTTP2 requests.
prakarsh-dt
reviewed
Aug 27, 2021
|
|
||
| ### Init Containers | ||
| ```yaml | ||
| initContainers: [] |
Collaborator
There was a problem hiding this comment.
Include Example, it would be almost same as Containers section
prakarsh-dt
reviewed
Aug 27, 2021
| ```yaml | ||
| server: | ||
| deployment: | ||
| deployment:0 |
prakarsh-dt
reviewed
Aug 27, 2021
| TargetCPUUtilizationPercentage: 90 | ||
| TargetMemoryUtilizationPercentage: 80 | ||
| ``` | ||
|
|
Collaborator
There was a problem hiding this comment.
Line 540 to 547 is not an example of custom metrics.
prakarsh-dt
approved these changes
Aug 27, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixed all broken images in user-access.md file.
Type of change
Checklist: