Deployment template #792
Merged
Deployment template #792
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
manish-agrawal-ai
approved these changes
Oct 14, 2021
nishant-d
pushed a commit
that referenced
this pull request
Nov 12, 2021
* deployment template WIP * json schema * json schema * sql name change * json files * json schema code * validate json * json schema validation * jsonSchemaValidation * DeploymentTemplateValidate * deploymentTemplate * updates json schema * schema json * deploymenttemplate * changed schema * docs update * deployment template valaidation * resolve code conflicts * no change * chart group auth issue fixred * deployment template * validator * deployment template * Deployment template (#790) * deployment template WIP * json schema * json schema * sql name change * json files * json schema code * validate json * json schema validation * jsonSchemaValidation * DeploymentTemplateValidate * deploymentTemplate * updates json schema * schema json * deploymenttemplate * changed schema * docs update * deployment template valaidation * resolve code conflicts * no change * deployment template * validator * deployment template Co-authored-by: nishant <nishant@devtron.ai> Co-authored-by: Aviral Srivastava <aviralsrivastava@Avirals-MacBook-Pro.local> * deployment-template * deployment template bug fix * deployment template validator log * bug fix * Deployment template (#792) * deployment template WIP * json schema * json schema * sql name change * json files * json schema code * validate json * json schema validation * jsonSchemaValidation * DeploymentTemplateValidate * deploymentTemplate * updates json schema * schema json * deploymenttemplate * changed schema * docs update * deployment template valaidation * resolve code conflicts * no change * deployment template * validator * deployment template * deployment-template * deployment template bug fix * deployment template validator log * bug fix Co-authored-by: nishant <nishant@devtron.ai> Co-authored-by: Aviral Srivastava <aviralsrivastava@Avirals-MacBook-Pro.local> * wip * wip * checking file * prometheus endpoint validating only if provided * Delete 466 * rewrite cross manager access issue * review points * deployment template update * file read * file exist * json schema * file check exist * final code * deployment template bug resolved * review changes * review change * review changes * changes * code review changes * review changes * docs update * docs table update * wire changes * format checker initialise * Create ValidatorHelper.go * json schema * schema changes * error message * env-template validation * deployment-template * doc changes * doc changes * doc changes Co-authored-by: nishant <nishant@devtron.ai> Co-authored-by: Aviral Srivastava <aviralsrivastava@Avirals-MacBook-Pro.local> Co-authored-by: Vikram Singh <vikram@devtron.ai> Co-authored-by: Manish Agrawal <manish@devtron.ai> Co-authored-by: Manish Agrawal <85211469+manish-agrawal-ai@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.
Fixes # (issue)
Type of change
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Checklist: