FIX: used float64 instead of int #884
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Autoscaling.MinReplicas and Autoscaling.MaxReplicas are giving type conversion error -
2021/11/19 10:40:54 http: panic serving 100.114.15.204:47584: interface conversion: interface {} is float64, not int
Fixes # (issue)
As per documentation at https://pkg.go.dev/encoding/json#Unmarshal
unspecified numbers are converted to float64 not int, therefore changed conversion to float64 instead of int.
Type of change
How Has This Been Tested?
This has been tested by updating the test case in ValidatorHelper_test.go
Checklist: